-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Compat for the Aether & Major Addons #7084
base: mc1.20.1/dev
Are you sure you want to change the base?
Data Compat for the Aether & Major Addons #7084
Conversation
dcd2dc1
to
253737f
Compare
does this currently work to fix the issues between aether and ancient aether? would this also fix deep aether as that is currently experiencing a similar problem even without ancient aether |
No, that’s not Create’s job, and it can’t. There’s no guarantee the worldgen files from Ancient Aether wouldn’t be loaded afterwards, and crash anyway.
I’m not aware of any incompatibility (my pack works fine) between Aether & Deep Aether. |
// The Aether | ||
AET_1 = cuttingCompat(Mods.AET, "skyroot"), | ||
AET_2 = stripAndMakePlanks(Mods.AET, "golden_oak_log", "stripped_skyroot_log", null), | ||
AET_3 = stripAndMakePlanks(Mods.AET, "golden_oak_wood", "stripped_skyroot_wood", null), | ||
|
||
// Deep Aether | ||
D_AET = cuttingCompat(Mods.D_AET, "roseroot", "yagroot", "cruderoot", "conberry", "sunroot"), | ||
|
||
// Ancient Aether | ||
A_AET = cuttingCompat(Mods.A_AET, "highsproot", "sakura"), | ||
|
||
// Aether Redux | ||
AET_R_1 = cuttingCompat(Mods.AET_R, "fieldsproot", "blightwillow", "crystal", "glacia"), | ||
AET_R_2 = stripAndMakePlanks(Mods.AET_R, "sporing_blightwillow_log", "stripped_blightwillow_log", null), | ||
AET_R_3 = stripAndMakePlanks(Mods.AET_R, "sporing_blightwillow_wood", "stripped_blightwillow_wood", null), | ||
AET_R_4 = stripAndMakePlanks(Mods.AET_R, "cloudcap_stem", "stripped_cloudcap_stem", "cloudcap_planks"), | ||
AET_R_5 = stripAndMakePlanks(Mods.AET_R, "cloudcap_hyphae", "stripped_cloudcap_hyphae", "cloudcap_planks"), | ||
AET_R_6 = stripAndMakePlanks(Mods.AET_R, null, "jellyshroom_stem", "jellyshroom_planks"), | ||
AET_R_7 = stripAndMakePlanks(Mods.AET_R, null, "jellyshroom_hyphae", "jellyshroom_planks") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overlaps with some changes that've been done privately to make these recipes easier to generate, could you revert the changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Adds/Expands data compat for:
Consists of:
Concerns
Data-wise
Code-wise
Generally, I've kept code changes to a minimum (helpers at most), except for:
Then there's some observations that would imo improve the codebase but seem out of scope of this PR (by adding code additions/changes + refactors into a primarily data PR)