Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination support to load cases #1303

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat: add pagination support to load cases #1303

merged 1 commit into from
Nov 21, 2024

Conversation

tabiodun
Copy link
Collaborator

  • Refactor loadCasesCached to loadCasesCachedWithPagination for enhanced pagination support.
  • Implement loadCasesPaginated function to handle API requests with pagination.
  • Update method invocations in PhoneSystem.vue, Work.vue, and dashboard.ts to use the new loadCasesCachedWithPagination.
  • Improve cache reconciliation logic to ensure data consistency.

- Refactor `loadCasesCached` to `loadCasesCachedWithPagination` for enhanced pagination support.
- Implement `loadCasesPaginated` function to handle API requests with pagination.
- Update method invocations in PhoneSystem.vue, Work.vue, and dashboard.ts to use the new `loadCasesCachedWithPagination`.
- Improve cache reconciliation logic to ensure data consistency.
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 98 lines in your changes missing coverage. Please review.

Project coverage is 19.00%. Comparing base (f3cc2d8) to head (6dabe66).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/worksite.ts 0.00% 95 Missing ⚠️
src/pages/Work.vue 0.00% 1 Missing ⚠️
src/pages/phone/PhoneSystem.vue 0.00% 1 Missing ⚠️
src/utils/dashboard.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
- Coverage   19.02%   19.00%   -0.03%     
==========================================
  Files         425      425              
  Lines       66426    66521      +95     
  Branches     1448     1448              
==========================================
  Hits        12639    12639              
- Misses      53787    53882      +95     
Flag Coverage Δ
unitTests 19.00% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Playwright test results

failed  1 failed
passed  46 passed
flaky  3 flaky

Details

stats  50 tests across 11 suites
duration  4 minutes, 17 seconds
commit  6dabe66

Failed tests

chromium › pages/user-profile.test.ts › UserProfile › should have visible data-testids - ( @primary @slow @read @development @staging @production )

Flaky tests

firefox › authentication.test.ts › Authentication › should redirect from login related unauthorized pages with existing session - ( @slow @primary @development @staging @production )
chromium › pages/dashboard.test.ts › DashboardPage › should have data-testids - ( @fast @primary @read @development @staging @production )
firefox › pages/user-profile.test.ts › UserProfile › should have visible data-testids - ( @primary @slow @read @development @staging @production )

@tabiodun tabiodun merged commit ab1aa47 into master Nov 21, 2024
15 of 18 checks passed
@tabiodun tabiodun deleted the tobi-develop branch November 21, 2024 15:31
Copy link

sentry-io bot commented Nov 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: e is undefined nav.work View Issue
  • ‼️ TypeError: Cannot read properties of undefined (reading 'results') nav.work_view_case View Issue
  • ‼️ TypeError: e is undefined nav.work View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant