Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone System Zoom and Focus Issue #865

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

pablo014
Copy link
Contributor

@pablo014 pablo014 commented May 20, 2024

This PR solves the zoom in and incident center issue.

In zooming the main issue was two things

  1. The hit box was sometimes too small to hit with a mouse causing users to zoom into a wrong area
  2. Sometimes the value of the maputil was not found so I made sure that there is always a maputils value before zooming in and out

In the jumping to incident center the main issue was that the coordinates being passed in were backwards

These were fixed by setting the coordinates correctly, increased the hit box for a given simple map and checking if there is a map utils value whenever you zoom in or out

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 18.99%. Comparing base (3fc0824) to head (2688192).

Files with missing lines Patch % Lines
src/pages/phone/PhoneSystem.vue 0.00% 7 Missing ⚠️
src/components/SimpleMap.vue 0.00% 4 Missing ⚠️
src/components/tags/LanguageTag.vue 0.00% 1 Missing ⚠️
src/hooks/live/useLiveChart.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   18.99%   18.99%           
=======================================
  Files         425      425           
  Lines       66526    66528    +2     
  Branches     1448     1451    +3     
=======================================
+ Hits        12638    12639    +1     
- Misses      53888    53889    +1     
Flag Coverage Δ
unitTests 18.99% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 20, 2024

Playwright test results

passed  45 passed
flaky  5 flaky

Details

stats  50 tests across 11 suites
duration  5 minutes, 2 seconds
commit  2688192

Flaky tests

firefox-setup › auth.setup.ts › authenticate as user - ( @primary @slow @read @development @staging @production )
firefox › authentication.test.ts › Authentication › should load unauthorized routes as expected with and without authentication - ( @slow @primary @development @staging @production )
firefox › pages/login.test.ts › LoginPage › should have data-testids - ( @fast @primary @read @development @staging @production )
chromium › pages/user-profile.test.ts › UserProfile › should have visible data-testids - ( @primary @slow @read @development @staging @production )
firefox › pages/user-profile.test.ts › UserProfile › should have visible data-testids - ( @primary @slow @read @development @staging @production )

@pablo014 pablo014 force-pushed the fix/simple-map-zoom branch from ef3754d to a7e5855 Compare May 21, 2024 23:09
@pablo014 pablo014 changed the title WIP: Phone System Zoom and Focus Issue Phone System Zoom and Focus Issue May 21, 2024
@pablo014 pablo014 requested a review from deepanchal May 21, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant