tests bugfixes

CristianDavideConte · Jan 13, 2024 · c6ee81b · c6ee81b
1 parent e15476f
commit c6ee81b
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 14 deletions.
diff --git a/cypress/e2e/isScrolling-tests.cy.js b/cypress/e2e/isScrolling-tests.cy.js
@@ -37,7 +37,6 @@ describe("isScrolling-scrollXAnimation", function () {
 });
 
 describe("isScrolling-scrollYAnimation", function () {
-    let uss;
     it("Tests the isScrolling method", function () {
         cy.window()
             .then((win) => {
@@ -68,7 +67,6 @@ describe("isScrolling-scrollYAnimation", function () {
 });
 
 describe("isScrolling-scrollXYAnimation", function () {
-    let uss;
     it("Tests the isScrolling method", function () {
         cy.window()
             .then((win) => {
@@ -99,7 +97,6 @@ describe("isScrolling-scrollXYAnimation", function () {
 });
 
 describe("isScrolling-StoppedScrollingWhileAnimating-scrollXAnimation", function () {
-    let uss;
     let _resolve;
     const _testCalculator = (i = 0) => {
         return (remaning, originalTimestamp, currentTimestamp, total, currentYPosition, finalYPosition, container) => {
@@ -138,7 +135,6 @@ describe("isScrolling-StoppedScrollingWhileAnimating-scrollXAnimation", function
 });
 
 describe("isScrolling-StoppedScrollingWhileAnimating-scrollYAnimation", function () {
-    let uss;
     let _resolve;
     const _testCalculator = (i = 0) => {
         return (remaning, originalTimestamp, currentTimestamp, total, currentYPosition, finalYPosition, container) => {
@@ -177,7 +173,6 @@ describe("isScrolling-StoppedScrollingWhileAnimating-scrollYAnimation", function
 });
 
 describe("isScrolling-StopXAxisScrollingWhileAnimating", function () {
-    let uss;
     let _resolve;
     const _testCalculator = (i = 0) => {
         return (remaning, originalTimestamp, currentTimestamp, total, currentYPosition, finalYPosition, container) => {
@@ -215,7 +210,6 @@ describe("isScrolling-StopXAxisScrollingWhileAnimating", function () {
 });
 
 describe("isScrolling-StopYAxisScrollingWhileAnimating", function () {
-    let uss;
     let _resolve;
     const _testCalculator = (i = 0) => {
         return (remaning, originalTimestamp, currentTimestamp, total, currentYPosition, finalYPosition, container) => {
@@ -253,7 +247,6 @@ describe("isScrolling-StopYAxisScrollingWhileAnimating", function () {
 });
 
 describe("isScrolling-StopBothAxisScrollingWhileAnimating", function () {
-    let uss;
     let _resolve;
     const _testCalculator = (i = 0) => {
         return (remaning, originalTimestamp, currentTimestamp, total, currentYPosition, finalYPosition, container) => {

diff --git a/cypress/e2e/isXScrolling-tests.cy.js b/cypress/e2e/isXScrolling-tests.cy.js
@@ -37,7 +37,6 @@ describe("isXScrolling", function () {
 });
 
 describe("isXScrolling-StoppedScrollingWhileAnimating", function () {
-    let uss;
     let _resolve;
     const _testCalculator = (i = 0) => {
         return (remaning, originalTimestamp, currentTimestamp, total, currentXPosition, finalXPosition, container) => {

diff --git a/cypress/e2e/isYScrolling-tests.cy.js b/cypress/e2e/isYScrolling-tests.cy.js
@@ -37,7 +37,6 @@ describe("isYScrolling", function () {
 });
 
 describe("isYScrolling-StoppedScrollingWhileAnimating", function () {
-    let uss;
     let _resolve;
     const _testCalculator = (i = 0) => {
         return (remaning, originalTimestamp, currentTimestamp, total, currentYPosition, finalYPosition, container) => {

diff --git a/cypress/e2e/scrollBy-tests.cy.js b/cypress/e2e/scrollBy-tests.cy.js
@@ -40,7 +40,6 @@ describe("scrollBy", function () {
 });
 
 describe("scrollToBy-StillStart-True", function () {
-    let uss;
     let oldFinalXPosition, oldFinalYPosition;
     let finalXPosition, finalYPosition;
 
@@ -74,7 +73,6 @@ describe("scrollToBy-StillStart-True", function () {
 });
 
 describe("scrollToBy-StillStart-False", function () {
-    let uss;
     let oldFinalXPosition, oldFinalYPosition;
     let finalXPosition, finalYPosition;
 
@@ -104,7 +102,6 @@ describe("scrollToBy-StillStart-False", function () {
 });
 
 describe("scrollToBy-StillStart-False-ExtendedScrollingWhileAnimating", function () {
-    let uss;
     let oldFinalXPosition;
     let oldFinalYPosition;
     let init = false;
@@ -148,7 +145,6 @@ describe("scrollToBy-StillStart-False-ExtendedScrollingWhileAnimating", function
 });
 
 describe("scrollBy-containScroll-below-0", function () {
-    let uss;
     let finalXPosition;
     let finalYPosition;
     it("Scrolls the test element by (n1,n2) pixels obtaining a finalXPosition and a finalYPosition lower than 0", function () {
@@ -186,7 +182,6 @@ describe("scrollBy-containScroll-below-0", function () {
 });
 
 describe("scrollBy-containScroll-beyond-maxScrollX-and-maxScrollY", function () {
-    let uss;
     let maxScrollX;
     let maxScrollY;
     let finalXPosition;

diff --git a/cypress/support/constants.js b/cypress/support/constants.js
@@ -21,6 +21,7 @@ const getChildrenRecursively = (element) => {
 const unsupportedElement = () => {};
 Object.setPrototypeOf(unsupportedElement, Element.prototype);
 
+//TODO: find a way to import the common.js keys instead of creating them from scratch
 export const constants = {
     K_IDX:0,   //Key to get the scroll id on the x-axis
     K_IDY:1,   //Key to get the scroll id on the y-axis