Ensure it works with Fastboot #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 3, 2020 13:43
The `didReceiveAttrs` was sometimes run multiple times, e.g. in Fastboot, leading to issues there. A CP will automatically use caching and not re-run if the message doesn't change.
Note: The availableLocales CP in the dummy app triggered an immediate re-render, which tripped up FastBoot.
This will ensure that if fingerprinting is enabled: * It will also fingerprint .json files * It will NOT fingerprint package.json, if FastBoot is used (this is generated by FastBoot on the fly) It also means that users will not need to adjust their config anymore. For clarity, we log any changes to the configuration in the console.
arm1n
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores FastBoot compatibility.
It is heavily inspired by https://github.com/adopted-ember-addons/ember-cli-ifa/pull/57/files.
There are basically two main issues that need to be worked around for FastBoot:
document.querySelector(...), asdocumentis not available in Nodeen.json) via XMLHttpRequest, as that is not available in NodeFor 1.), I used the same approach as the one in the references PR to ember-cli-ifa, to build a custom module for Node which can be requested in FastBoot environment (this is encapsulated in the new
utils/get-locale-asset-map.jsfile).For 2.), we embed the actual locale file content in the asset map, instead of the path to the asset map, for the FastBoot module. This way, we avoid needing to make any Ajax requests in FastBoot environment.
FastBoot will also generate a
package.jsonfile in the output, which needs to be excluded from fingerprinting. This PR will automatically adjust the fingerprinting options to work with ember-l10n now, including addingjsontofingerprint.extensionsfor you. The user is informed about any changes made to the configuration in the console, e.g.:Note that it does not actually add FastBoot as a dev dependency, and does not add any FastBoot tests for now. I did install FastBoot locally and tried it, to ensure it works as expected (which it did for me).
Fixes #59