Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add else if Conditional Statements to the Metal backend #34

Closed
3 tasks
samthakur587 opened this issue Aug 10, 2024 · 15 comments · Fixed by #39
Closed
3 tasks

Add else if Conditional Statements to the Metal backend #34

samthakur587 opened this issue Aug 10, 2024 · 15 comments · Fixed by #39
Assignees
@adityanarayanan343
Labels
good first issue Good for newcomers ToDO A ToDO list of task

Comments

@samthakur587
Copy link
Contributor

samthakur587 commented Aug 10, 2024 •
edited
Loading

To add else if support to CrossGL, modify the following files in the crosstl/src/backend/Metal directory:

  • MetalLexer.py : Add token recognition for else if.
  • MetalParser.py : Update grammar and AST to handle else if.
  • MetalCrossGLCodeGen.py : Implement else if for Crossgl output.

Your contribution is appreciated! Feel free to reach out on our Discord Server if you have any query.
@samthakur587 samthakur587 added good first issue Good for newcomers ToDO A ToDO list of task labels Aug 10, 2024
adityanarayanan343 added a commit to adityanarayanan343/crosstl that referenced this issue Aug 20, 2024
@adityanarayanan343
Added else if Conditional Statements to the Metal backend CrossGL#34
cb28c0d
@adityanarayanan343
Copy link
Contributor

Hi I would like to work on this issue. So kindly assign me this issue

@NripeshN NripeshN mentioned this issue Aug 20, 2024
Merged
adityanarayanan343 added a commit to adityanarayanan343/crosstl that referenced this issue Aug 20, 2024
@adityanarayanan343
Fix: Fixed the code for the mentioned issues CrossGL#34
68d86c3
@rohansawant0735
Copy link

Hi, I’d like to work on this issue. Could you please assign it to me?

  • Rohan

@NripeshN
Copy link
Member

Hi, I’d like to work on this issue. Could you please assign it to me?

  • Rohan

Hi @rohansawant0735
This issue is currently being worked by @adityanarayanan343. Feel free to go through our other unassigned issues or create a new issue if you're interested in contributing to our repo😁

@revanthreddy13
Copy link

intrested to work on the isuue

adityanarayanan343 added a commit to adityanarayanan343/crosstl that referenced this issue Aug 22, 2024
@adityanarayanan343
Fixed and Ran tests for issue CrossGL#34
3b19975
@vishwa8904
Copy link

vishwa8904 commented Aug 23, 2024 •
edited
Loading

Hi I would like to work on this issue. So please kindly assign it to me #34 @NripeshN

@Deependra248 Deependra248 mentioned this issue Aug 24, 2024
Open
19 tasks
@kartik-singh-droid
Copy link

kartik-singh-droid commented Aug 25, 2024 •
edited
Loading

Hi interested to work on this issue . So kindly assign it to me @NripeshN @samthakur587

@pratikmhadgut
Copy link

Hi I would like to work on this issue. So kindly assign me this issue

@Ash-creater
Copy link

I would like to work on this issue.So kindly assign me this issue.

@rishabhr03
Copy link

rishabhr03 commented Aug 26, 2024 •
edited
Loading

I would like to work on this issue @NripeshN

@therishabhsharma03
Copy link

@NripeshN
I would like to work on this issue

@faizanfayazmir1
Copy link

Hi @NripeshN @samthakur587,

I am very interested in working on this issue and would like to take it on. Could you please assign it to me?

Thank you!

Best regards,
Faizan Fayaz Mir

@shreekrsna
Copy link

shreekrsna commented Aug 29, 2024 •
edited
Loading

Hi @NripeshN I would like to work on the above issue, so kindly assign me the task.

samthakur587 added a commit that referenced this issue Aug 29, 2024
@adityanarayanan343 @pre-commit-ci @samthakur587
Added else if Conditional Statements to the Metal backend #34 (#39)
c5bc4c5 
* Added else if Conditional Statements to the Metal backend #34

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Fixed the code for the mentioned issues #34

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Minor Fixes

* Fixed and Ran tests for issue #34

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Minor Fixes for else_if in MetalCrossGLCodeGen.

* Added If test condition

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Minor Fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixing else if output for test cases

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Minor Fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: Fixed Parser

* Fixed MetalParser.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix: Made requested changes for the MetalParser.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix : Made the changes in Metalparser.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Minor Fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix: fixed multiple else if statement generation

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: samthakur587 <samunder268@gmail.com>
@shreekrsna
Copy link

shreekrsna commented Aug 29, 2024 via email

@kumVij
Copy link

kumVij commented Aug 31, 2024

I would like to work on the #34 issue , Kindly assign me the task .

@RajvanshMalhotra
Copy link

hey @NripeshN i had been assigned this issue are there any new issues that i could contribute to ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityanarayanan343 adityanarayanan343

Labels
good first issue Good for newcomers ToDO A ToDO list of task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added else if Conditional Statements to the Metal backend #34 adityanarayanan343/crosstl