Implement tokens for unsigned int and double data types #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samthakur587
requested changes
Aug 22, 2024
crosstl/src/translator/lexer.py
Outdated
| @@ -17,6 +17,8 @@ | |||
| ("FLOAT_NUMBER", r"\d*\.\d+|\d+\.\d*"), | |||
| ("FLOAT", r"\bfloat\b"), | |||
| ("INT", r"\bint\b"), | |||
| ("UINT", r"\bunsigned\s+int\b"), | |||
There was a problem hiding this comment.
hii @rigved-desai for the UINT token we are defining uint not unsigned int can you please change it to uint only .
There was a problem hiding this comment.
Updated in latest commit 👍
samthakur587
approved these changes
Aug 22, 2024
AxelB1011
pushed a commit
to AxelB1011/crosstl
that referenced
this pull request
Aug 22, 2024
* feat: Implement tokens for unsigned int and double data types. * chore: Add test for data type tokenization * feat: Refactor unsigned int to uint after review and edit tests for same
3 tasks
samthakur587
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Added else if to translator * Removed comment(s) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added else if support to Directx backend * added Assignment and, assignment or, assignment xor, xor , assignemnt modulus and modulus to the translator frontend. closes #48,#50,#51,#52,#53 * tests for else_if added * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Implement tokens for unsigned int and double data types (#68) * feat: Implement tokens for unsigned int and double data types. * chore: Add test for data type tokenization * feat: Refactor unsigned int to uint after review and edit tests for same * fix for multiple else if conditionals * more fixes for multiple else if conditionals * More fixes * Missing newline * fix CI error * fix CI error * Removed name=main * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added tests for multiple if statements --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nripesh Niketan <nripesh14@gmail.com> Co-authored-by: Prithvi-Rao <ee22b024@smail.iitm.ac.in> Co-authored-by: rigved-desai <109571041+rigved-desai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces the following changes:
uint(UINT) anddouble(DOUBLE) have been implemented inlexer.py.test_lexer.py,Related Issue
This PR attempts to solve the following issues:
Closes #58
Closes #59
Checklist