Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/test member enrichment with logs #1953

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

themarolt
Copy link
Contributor

@themarolt themarolt commented Dec 12, 2023

Changes proposed ✍️

What

🤖[deprecated] Generated by Copilot at cdee997

This pull request improves the error handling and logging of the memberEnrichmentService and prevents duplicate records in the memberToMerge table. These changes enhance the reliability and performance of the premium member profile enrichment feature.

🤖[deprecated] Generated by Copilot at cdee997

We are the members of the merge
We defy the duplicates and the errors
We seek the data from beyond
We enrich our profiles with the secrets

Why

How

🤖[deprecated] Generated by Copilot at cdee997

  • Prevent duplicate records and errors when inserting potential member matches into the memberToMerge table by adding on conflict do nothing clause to the SQL query (link)
  • Handle and log errors that might occur during the synchronization and enrichment of member data with external sources by adding try-catch blocks and log statements to the memberEnrichmentService class methods (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@themarolt themarolt marked this pull request as ready for review December 12, 2023 15:11
@themarolt themarolt merged commit 7fc3d06 into main Dec 12, 2023
5 checks passed
@themarolt themarolt deleted the improvement/test-member-enrichment-with-logs branch December 12, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants