Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/test member enrichment with logs #1953

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Improvement/test member enrichment with logs #1953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b22b4ab
syncing members try/catch within member enrichment
epipav Dec 12, 2023
d03305d
add on conflict do nothing to addToMerge function
epipav Dec 12, 2023
2d82d5a
added an error log
Dec 12, 2023
cdee997
Merge branch 'improvement/test-member-enrichment-with-logs' of github…
Dec 12, 2023
64f7c98
remove try/catch in memberEnrichment sync
epipav Dec 12, 2023
b1a44ee
Merge branch 'improvement/test-member-enrichment-with-logs' of github…
epipav Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/database/repositories/memberRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ class MemberRepository {

const query = `
INSERT INTO "memberToMerge" ("memberId", "toMergeId", "similarity", "createdAt", "updatedAt")
VALUES ${placeholders.join(', ')};
VALUES ${placeholders.join(', ')} on conflict do nothing;
`
try {
await seq.query(query, {
Expand Down
1 change: 1 addition & 0 deletions backend/src/services/premium/enrichment/memberEnrichmentService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ export default class MemberEnrichmentService extends LoggerBase {
await SequelizeRepository.commitTransaction(transaction)
return result
} catch (error) {
this.log.error(error, 'Error while enriching a member!')
await SequelizeRepository.rollbackTransaction(transaction)
throw error
}
Expand Down
Loading