Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-selected remote filters #1972

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Dec 15, 2023

Changes proposed ✍️

What

🤖[deprecated] Generated by Copilot at 9cc52e3

Updated the organizations filter in the activity, member, and organization modules to use id as the value field and to sort the options alphabetically by name. This improves the filter's consistency and usability across the frontend.

🤖[deprecated] Generated by Copilot at 9cc52e3

Sing, O Muse, of the skillful coder who refined the filters
Of organizations, those noble groups of heroes and of leaders,
Who made them use the id field, not the name, as the key
And sorted them by alphabet, for clarity and ease.

Why

How

🤖[deprecated] Generated by Copilot at 9cc52e3

  • Changed the remotePopulateItems function for the organizations filter in the activity, member, and organization modules to use the query method instead of the listAutocomplete method of the OrganizationService (link, link, link). This allows sorting the results by the display name of the organizations.

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Dec 15, 2023
@joanagmaia joanagmaia self-assigned this Dec 15, 2023
@joanagmaia joanagmaia merged commit 0b4fa7d into main Dec 15, 2023
5 checks passed
@joanagmaia joanagmaia deleted the bugfix/custom-view-pre-filter branch December 15, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants