Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] policy_id key is missing from body payload handler for the update_policy_container operation. #1068

Closed
jshcodes opened this issue Nov 9, 2023 · 0 comments · Fixed by #1079
Closed

[ BUG ] policy_id key is missing from body payload handler for the update_policy_container operation. #1068

jshcodes opened this issue Nov 9, 2023 · 0 comments · Fixed by #1079
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working firewall Firewall Policies and Management issues and questions

Comments

@jshcodes
Copy link
Member

jshcodes commented Nov 9, 2023

Describe the bug
The body payload abstraction handler for update_policy_container is missing the policy_id key.

To Reproduce
Create an instance of the FirewallManagement service class and then make a call to the update_policy_container operation. Make sure to include the policy_id keyword argument. This argument will not be processed and the key will not be provided as part of the body payload sent to the API.

Expected behavior
The payload handler properly ingests the key value and adds it to the body payload.

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: Up to 1.3.3

Additional context
Discovered while investigating #1059.
@jshcodes jshcodes added bug 🐛 Something isn't working firewall Firewall Policies and Management issues and questions labels Nov 9, 2023
@jshcodes jshcodes self-assigned this Nov 9, 2023
jshcodes added a commit that referenced this issue Nov 10, 2023
@jshcodes
Fix update_policy_container payload handler. Closes #1068. Relates to #…
0bf5b04 
…1059.
jshcodes added a commit that referenced this issue Nov 10, 2023
@jshcodes
Fix update_policy_container payload handler. Closes #1068. Relates to #…
32cef1c 
…1059.
jshcodes added a commit that referenced this issue Nov 18, 2023
@jshcodes
Fix update_policy_container payload handler. Closes #1068. Relates to #…
15a7be4 
…1059.
@jshcodes jshcodes mentioned this issue Nov 20, 2023
Merged
5 tasks
jshcodes added a commit that referenced this issue Nov 21, 2023
@jshcodes
Fix update_policy_container payload handler. Closes #1068. Relates to #…
1603fb7 
…1059.
@jshcodes jshcodes mentioned this issue Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working firewall Firewall Policies and Management issues and questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.3.4 - Context manager support, bug fixes and operation updates CrowdStrike/falconpy
1 participant
@jshcodes