Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] Per-operation pythonic override is not working as expected #1078

Closed
jshcodes opened this issue Nov 20, 2023 · 0 comments · Fixed by #1079
Closed

[ BUG ] Per-operation pythonic override is not working as expected #1078

jshcodes opened this issue Nov 20, 2023 · 0 comments · Fixed by #1079
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working SDK usage General SDK usage issues and questions

Comments

@jshcodes
Copy link
Member

Describe the bug
The pythonic keyword is not being properly passed from the process_service_request method to the service_request method.

To Reproduce
Create an instance of a Service Class that has pythonic responses disabled. Call any operation and provide the pythonic keyword set to True. You will still receive dictionary output.

Expected behavior
Pythonic responses can be enabled per operation.

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: v1.3.0 - 1.3.3
@jshcodes jshcodes added bug 🐛 Something isn't working SDK usage General SDK usage issues and questions labels Nov 20, 2023
@jshcodes jshcodes self-assigned this Nov 20, 2023
jshcodes added a commit that referenced this issue Nov 20, 2023
@jshcodes
Fix per operation pythonic override. Closes #1078.
6038cba
jshcodes added a commit that referenced this issue Nov 20, 2023
@jshcodes
Fix per operation pythonic override. Closes #1078.
19d5828
@jshcodes jshcodes mentioned this issue Nov 20, 2023
Merged
5 tasks
jshcodes added a commit that referenced this issue Nov 20, 2023
@jshcodes
Fix per operation pythonic override. Closes #1078.
2f2d2a6
jshcodes added a commit that referenced this issue Nov 21, 2023
@jshcodes
Fix per operation pythonic override. Closes #1078.
acddc5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working SDK usage General SDK usage issues and questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.3.4 - Context manager support, bug fixes and operation updates CrowdStrike/falconpy
1 participant
@jshcodes