Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when creating a variable with create_variable() and passing subvariab… #374

Merged
merged 2 commits into from
Sep 15, 2019

Conversation

mathiasbc
Copy link
Contributor

…les with id and alias, respect those in favor of default values generated by Crunch

…les with id and alias, respect those in favor of default values generated by Crunch
@alextanski
Copy link

Great. Let's remove code for getting the id for clearity. Crunch derives it from the url of the subreference autonomously.

scrunch/datasets.py Outdated Show resolved Hide resolved
Copy link

@alextanski alextanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting rid of get('id').

@xbito xbito merged commit 182c069 into master Sep 15, 2019
@xbito xbito deleted the issue-373 branch September 15, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants