Confirming Implementation of URLBASE and BASEPATH?

[brettpalmberg]

Question / Bug?

Hosting pg_featureserv at a non-root path required including the path parameter (e.g. /features) in both the UrlBase and BasePath config params to get URLs and JSON values to form correctly. It felt redundant to have to include the BasePath in both variables, but wanted to confirm whether this is the intended behavior before calling anything a bug.

Example (this works)

To host pg_featureserv at localhost:9000/features/ for example, the following environment variables are required to make all .html links and JSON-built urls work correctly:

• PGFS_SERVER_URLBASE=http://localhost:9000/features
• PGFS_SERVER_BASEPATH=/features

What I expected (this does not work)

• PGFS_SERVER_URLBASE=http://localhost:9000
• PGFS_SERVER_BASEPATH=/features

Thank you.

[brettpalmberg]

Related to #109. I was able to confirm that the behavior of URLBASE and BASEPATH configuration parameters behave differently between pg_tileserv and pg_featureserv. pg_tileserv behaves as described in the section What I expected (this does not work) above.

[dr-jts]

Thanks, @brettpalmberg . I agree that having no redundancy between URLBASE and BASEPATH is desirable. And so is compatibility between pg_featureserv and pg_tileserv. We'll investigate making this change.

[brettpalmberg]

Excellent, thanks for your response @dr-jts! Feel free to @ me if there's anything I can contribute. I wasn't familiar enough with the codebase just yet to be comfortable jumping-in :)

[rhewy]

Can these environment variables be passed to the docker container?

[pramsey]

Yes! Note that a Configuration.Variable will get converted into a PGFS_CONFIGURATION_VARIABLE if you catch my drift. There's a standard prefix (PGFS_) and everything gets caps'ed and underscored. But you can use normal environment variable passing to send the variable into docker or podman.

[rhewy]

So in a docker env file would I?
PGFS_SERVER_URLBASE=https://vm103.athena.bcit.ca/pgfs
PGFS_SERVER_BASEPATH=/pgfs

or

SERVER_URLBASE=https://vm103.athena.bcit.ca/pgfs
SERVER_BASEPATH=/pgfs

[pramsey]

The former

…

On Mon, Nov 7, 2022 at 12:29 PM Robert Hewlett ***@***.***> wrote: So in a docker env file would I? PGFS_SERVER_URLBASE=https://vm103.athena.bcit.ca/pgfs PGFS_SERVER_BASEPATH=/pgfs or SERVER_URLBASE=https://vm103.athena.bcit.ca/pgfs SERVER_BASEPATH=/pgfs — Reply to this email directly, view it on GitHub <#119 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA3ZWY74JROPSR34N3JJWLWHFRENANCNFSM55I2WA2Q> . You are receiving this because you commented.Message ID: ***@***.***>

[rhewy]

So, I have nginx as the reverse proxy for https

        location /pgfs/ {
             proxy_pass http://localhost:9000/ ;
        }

Then https://vm103.athena.bcit.ca/pgfs is a 404
However
https://vm103.athena.bcit.ca/pgfs/pgfs/
Works

Then from the links on the collections page:
https://vm103.athena.bcit.ca/pgfs/pgfs/collections.html

The links are missing the second /pgfs/
https://vm103.athena.bcit.ca/pgfs/collections/public.becpas.html
404 error for the above

I will try some things ...

[rhewy]

This worked for me:

PGFS_SERVER_URLBASE=https://vm103.athena.bcit.ca/pgfs
PGFS_SERVER_BASEPATH=/

Home links work too

Thank you!