Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for swift 2.x #2

Merged
merged 2 commits into from
Dec 22, 2015
Merged

updated for swift 2.x #2

merged 2 commits into from
Dec 22, 2015

Conversation

dbradby
Copy link
Contributor

@dbradby dbradby commented Dec 1, 2015

I think the git submodule reference also needs to update from UInt256, but this commit doesn't include it sorry

@Sjors
Copy link
Contributor

Sjors commented Dec 1, 2015

Thanks, I'll look into it later this week to make sure the submodule still works. Rather than submodules it might be better to publish these components as e.g. Cocoa pods, but I don't have time to look into that.

@dbradby
Copy link
Contributor Author

dbradby commented Dec 1, 2015

I'm happy to move them over to cocoapods too rather than deal with submodules. I'll do the Swift conversion first though

@Sjors
Copy link
Contributor

Sjors commented Dec 1, 2015

That sounds great, thanks!

On Tue, Dec 1, 2015 at 10:14 AM, dbradby notifications@github.com wrote:

I'm happy to move them over to cocoapods too rather than deal with
submodules. I'll do the Swift conversion first though


Reply to this email directly or view it on GitHub
#2 (comment).

Sjors added a commit that referenced this pull request Dec 22, 2015
@Sjors Sjors merged commit 8ac09c6 into CryptoCoinSwift:master Dec 22, 2015
@Sjors
Copy link
Contributor

Sjors commented Dec 22, 2015

Sorry for the delay. I merged it.

Didn't Apple just release a package management system for Swift?

Well, anything is better than submodules...

@Sjors
Copy link
Contributor

Sjors commented Dec 22, 2015

I made a ticket specially for the dependency management issue: CryptoCoinSwift/CryptoCoinFramework#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants