Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file explorer #2

Closed
wants to merge 10 commits into from
Closed

Conversation

OlshaMB
Copy link

@OlshaMB OlshaMB commented Apr 27, 2023

I want to improve file explorer usability

Roadmap

  • Create folder
  • Actions on file
    • Create new file on folder
    • Create new folder on folder
    • Delete File

@OlshaMB
Copy link
Author

OlshaMB commented Apr 27, 2023

@Cubxity what icons do you use for typstudio?

@Cubxity
Copy link
Owner

Cubxity commented Apr 27, 2023

Hi, thank you for contributing! Please mark the PR as draft if this is still W.I.P. Also, typstudio uses pnpm, please remove yarn.lock from the PR.

@Cubxity
Copy link
Owner

Cubxity commented Apr 27, 2023

@Cubxity what icons do you use for typstudio?

Material Icons.

@OlshaMB
Copy link
Author

OlshaMB commented Apr 27, 2023

Ok i will remove yarn.lock

@OlshaMB OlshaMB marked this pull request as draft April 27, 2023 14:51
@OlshaMB
Copy link
Author

OlshaMB commented Apr 27, 2023

@Cubxity what icons do you use for typstudio?

Material Icons.

Sidequestion: shouldn't you credit them?

@OlshaMB OlshaMB marked this pull request as ready for review April 29, 2023 15:27
@OlshaMB
Copy link
Author

OlshaMB commented Apr 29, 2023

I think the pr is done. I also needed to add confirm dialog to ask before deletion.

@Cubxity
Copy link
Owner

Cubxity commented May 8, 2023

Hey, can you rebase and resolve the conflicts?

Copy link
Collaborator

@caoimhebyrne caoimhebyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a few nitpicks

src/components/ShellModal.svelte Outdated Show resolved Hide resolved
src/lib/ipc/fs.ts Show resolved Hide resolved
src/lib/stores.ts Show resolved Hide resolved
@OlshaMB OlshaMB requested a review from caoimhebyrne May 9, 2023 09:20
Copy link
Owner

@Cubxity Cubxity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that creating directories and files should be hidden in a context menu. This removes clutter from the UI. Same goes for deletion.

src/components/ExplorerNode.svelte Outdated Show resolved Hide resolved
@OlshaMB
Copy link
Author

OlshaMB commented May 9, 2023

I believe that creating directories and files should be hidden in a context menu. This removes clutter from the UI. Same goes for deletion.

@Cubxity Maybe show the icons only on hover?
This also will remove clutter, but unlike a context menu you would feel that you are creating it on a directory not on a file explorer

@Cubxity
Copy link
Owner

Cubxity commented May 9, 2023

I believe that creating directories and files should be hidden in a context menu. This removes clutter from the UI. Same goes for deletion.

@Cubxity Maybe show the icons only on hover?
This also will remove clutter, but unlike a context menu you would feel that you are creating it on a directory not on a file explorer

That sounds alright.

@Csega
Copy link

Csega commented Jun 6, 2023

Hi Guys!

What is the status of this PR? Can you comment on it? Is it still in progress or just hanging?

Cheers,
Csega

@OlshaMB
Copy link
Author

OlshaMB commented Jun 7, 2023

I am busy right now so the pr is a hanged for now but I think I will return to this pr this weekend and finish it.

@caoimhebyrne
Copy link
Collaborator

Are you continuing this PR @OlshaMB?

@OlshaMB
Copy link
Author

OlshaMB commented Jul 17, 2023

yes

@OlshaMB OlshaMB requested a review from Cubxity July 17, 2023 18:54
@OlshaMB
Copy link
Author

OlshaMB commented Jul 17, 2023

@caoimhebyrne Done

@Cubxity
Copy link
Owner

Cubxity commented Aug 21, 2023

Could you rebase/resolve conflicts?

@caoimhebyrne
Copy link
Collaborator

caoimhebyrne commented Oct 29, 2023

@OlshaMB are you planning on continuing to maintain this PR? If not, please let us know ☺️

@OlshaMB
Copy link
Author

OlshaMB commented Nov 8, 2023

@OlshaMB are you planning on continuing to maintain this PR? If not, please let us know ☺️

No, I am not planning, I am not interested in typst right now(waiting for html output) and there are too much changes to merge

@caoimhebyrne
Copy link
Collaborator

Ok, I will close the PR and open an issue for improving the file explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants