Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed /system_status logging #567

Merged
merged 19 commits into from
Jun 29, 2023
Merged

removed /system_status logging #567

merged 19 commits into from
Jun 29, 2023

Conversation

NikitaPoly
Copy link
Contributor

@NikitaPoly NikitaPoly commented Jun 21, 2023

/system_status only gets logged when 200 status code is not present

mantarray_log__2023_06_28_225724.txt

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (46d098a) 100.00% compared to head (1c1ab07) 100.00%.

❗ Current head 1c1ab07 differs from pull request most recent head 105575f. Consider uploading reports for the commit 105575f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #567   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         6630      6630           
  Branches      1000      1000           
=========================================
  Hits          6630      6630           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mantarray_desktop_app/utils/log_formatter.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luciipak
Copy link
Contributor

Could you also attach a log file with these changes applied?

src/mantarray_desktop_app/main.py Outdated Show resolved Hide resolved
src/mantarray_desktop_app/main.py Outdated Show resolved Hide resolved
src/mantarray_desktop_app/main.py Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@NikitaPoly
Copy link
Contributor Author

NikitaPoly commented Jun 22, 2023

Could you also attach a log file with these changes applied?

Attached logs to the description of this PR

CHANGELOG.rst Outdated Show resolved Hide resolved
@NikitaPoly NikitaPoly force-pushed the remove_/system_status_log branch 4 times, most recently from bfdb4db to 6ce96ed Compare June 23, 2023 22:38
@NikitaPoly NikitaPoly merged commit bddee69 into main Jun 29, 2023
2 checks passed
@NikitaPoly NikitaPoly deleted the remove_/system_status_log branch June 29, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants