-
-
Notifications
You must be signed in to change notification settings - Fork 76
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: properly handle class sharing class name and namespace group name
- Loading branch information
Showing
3 changed files
with
63 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
tests/Integration/Mapping/Namespace/SameClassNameAsNamespaceGroupMappingTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace CuyZ\Valinor\Tests\Integration\Mapping\Namespace; | ||
|
||
use CuyZ\Valinor\Mapper\MappingError; | ||
use CuyZ\Valinor\Tests\Integration\IntegrationTestCase; | ||
use SomeNamespace\SomeClass; | ||
use SomeNamespace\SomeNamespace; | ||
|
||
final class SameClassNameAsNamespaceGroupMappingTest extends IntegrationTestCase | ||
{ | ||
// @see https://github.com/CuyZ/Valinor/issues/554 | ||
public function test_class_name_has_same_name_as_namespace_group_dot_not_block_type_resolution(): void | ||
{ | ||
require_once 'class-name-with-same-name-as-namespace-group.php'; | ||
|
||
try { | ||
$result = $this->mapperBuilder()->mapper()->map(ClassContainingNamespacedClasses::class, [ | ||
'objectA' => ['stringValue' => 'foo'], | ||
'objectB' => ['integerValue' => 42], | ||
]); | ||
} catch (MappingError $error) { | ||
$this->mappingFail($error); | ||
} | ||
|
||
self::assertSame('foo', $result->objectA->stringValue); | ||
self::assertSame(42, $result->objectB->integerValue); | ||
} | ||
} | ||
|
||
final class ClassContainingNamespacedClasses | ||
{ | ||
public SomeNamespace $objectA; | ||
public SomeClass $objectB; | ||
} |
13 changes: 13 additions & 0 deletions
13
tests/Integration/Mapping/Namespace/class-name-with-same-name-as-namespace-group.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<?php | ||
|
||
namespace SomeNamespace; | ||
|
||
final class SomeNamespace | ||
{ | ||
public string $stringValue; | ||
} | ||
|
||
final class SomeClass | ||
{ | ||
public int $integerValue; | ||
} |