Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid TypeScript configuration #317

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix invalid TypeScript configuration #317

merged 1 commit into from
Jan 15, 2024

Conversation

theodorejb
Copy link
Contributor

The module and moduleResolution settings are compiler options, and thus must be part of the compilerOptions object to take effect. NodeNext and Node16 are the only correct module options for code intended to run in Node.js 12+.

Per the documentation: 1

node16 and nodenext are the only correct module options for all apps and libraries that are intended to run in Node.js v12 or later, whether they use ES modules or not.

Note: the option values are case-insensitive, and I used the casing matching the JSON schema and suggested by VS Code.

@Cweili Cweili merged commit d13ceec into Cweili:master Jan 15, 2024
3 checks passed
@Cweili
Copy link
Owner

Cweili commented Jan 15, 2024

Thanks!

@theodorejb theodorejb deleted the fix-invalid-tsconfig branch January 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants