Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use io.ReadFull in NextMessage to handle short reads (#22) #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pjuhasz
Copy link

@pjuhasz pjuhasz commented Mar 31, 2024

This commit fixes issue #22.

To recap: it is not valid to assume that the entire packet is going to be available with a single Read() call.

Interestingly, a similar issue was raised by PR #5, on the asterisk side. However, that fix was not merged into mainline asterisk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants