Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tipi.build instructions #688

Merged
merged 2 commits into from
Mar 10, 2022
Merged

tipi.build instructions #688

merged 2 commits into from
Mar 10, 2022

Conversation

pysco68
Copy link
Contributor

@pysco68 pysco68 commented Mar 10, 2022

Hey! I Love your library! I was asked by a customer if/how they would use it in a tipi.build project amidst a demo session. I thought you might be happy to add the instructions to the readme etc.

I went ahead and added a CI step to test is building the project (and depending on it) still work as expected. Feel free to remove that, here's how the result would look like: https://github.com/tipi-deps/xxHash/actions/runs/1962088487

Best,

  • Yannic

@Cyan4973
Copy link
Owner

That's fine @pysco68 ,
I like that most changes are within a .tipi sub-directory,
so the only "visible" part affecting non-tipi users is the documentation part.

Let's get these CI tests working, and it will be good to go.

@pysco68
Copy link
Contributor Author

pysco68 commented Mar 10, 2022

Looks like this time it was fine. I saw that one of the Linux images failed on an apt install which looked like a broken package mirror.

How should we move on?

@Cyan4973
Copy link
Owner

Let's merge it.
I'll take care of the rest on my side.

@Cyan4973 Cyan4973 merged commit 4c223a5 into Cyan4973:dev Mar 10, 2022
@Cyan4973 Cyan4973 mentioned this pull request Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants