Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fix for Haiku #696

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Build fix for Haiku #696

merged 1 commit into from
Apr 6, 2022

Conversation

Begasus
Copy link
Contributor

@Begasus Begasus commented Mar 29, 2022

No description provided.

@Begasus
Copy link
Contributor Author

Begasus commented Mar 29, 2022

This is actually for the first failing test:

cli/xsum_os_specific.c:78:35: error: unused parameter 'stream'

@Begasus
Copy link
Contributor Author

Begasus commented Mar 29, 2022

I've added a new version to our haikuports based on the current commit, part of the patch is here the other one can be found here: https://github.com/Begasus/haikuports/blob/52f725755a883cca5153dc2ae177aaa651b77f13/dev-libs/xxhash/patches/xxhash-0.8.1%7Egit.patchset
Not sure if the other 2 are fine to be upstreamed (well maybe a ifneq for Haiku for -pthread could be added, will hear from you) :)

@Cyan4973 Cyan4973 merged commit 9244d6e into Cyan4973:dev Apr 6, 2022
@Begasus
Copy link
Contributor Author

Begasus commented Apr 6, 2022

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Begasus @Cyan4973