Fix issue #724 #730
Merged
Fix issue #724 #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main() introduces new variable algoBitmask which represents the algorithm(s) which will be accepted by the CLI. main() also sets suitable algoBitmask for exename and passes it to XSUM_checkFiles(). The default algoBitmask is algo_bitmask_all which accepts all xxh algorithms. XSUM_checkFiles() passes algoBitmask to XSUM_checkFile(). XSUM_checkFile() sets algoBitmask to XSUM_parseFileArg->algoBitmask and invokes XSUM_parseFile1(). XSUM_parseFile1() passes algoBitmask to XSUM_parseLine(). XSUM_parseLine() passes algoBitmask to XSUM_parseLine1(). XSUM_parseLine1() calles XSUM_algoBitmask_Accepts() to check actual xxh algorithm of the line and algoBitmask matches or not.
Cyan4973
approved these changes
Jul 29, 2022
|
Thanks @t-mat ! That's a great addition ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #724.
(1) Introduces new
enum AlgoBitmaskwhich represents xxh algorithm(s) as a bitmask(s). With this type, eachxxhsumsymlink variant indicates their acceptance.(2) Adds all possible 4x4 test matrix to the
Makefile. 4 means{ xxhsum, xxh32sum, xxh64sum, xxh128sum }.