Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add gcc -Og check and fix its false positive warnings #814

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

t-mat
Copy link
Contributor

@t-mat t-mat commented Mar 6, 2023

Before adding gcc-12 and -Og test to our CI, I'd like to fix gcc -Og issue.
See also #810

Actually, this is a false positve of gcc -Og. So there must be another ways to avoid this warning.
But since it seems there's easy / safe / explicit fix for it with negilible const, I'd like to it to XXH3_INITSTATE().
( See advice #810 (comment) from @easyaspi314 )

@t-mat
Copy link
Contributor Author

t-mat commented Mar 7, 2023

note: Test badge shows red ❌ , but it actually means "some tests are skipped". #817 fixes this issue.

@t-mat t-mat changed the title Fix: add gcc -Og check and its false positive warnings Fix: add gcc -Og check and fix its false positive warnings Mar 7, 2023
@Cyan4973 Cyan4973 merged commit a568bee into Cyan4973:dev Mar 9, 2023
@Cyan4973 Cyan4973 mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants