Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed tipi test from CI suite because it's unstable #841

Merged
merged 2 commits into from
Jun 19, 2023
Merged

removed tipi test from CI suite because it's unstable #841

merged 2 commits into from
Jun 19, 2023

Conversation

Cyan4973
Copy link
Owner

I wonder if I should also remove the files in .tipi/ directory.

These files are essentially empty, so they don't seem to add much value.

On the other hand, I'm not sure if such an action would break something, like an external build system depending on this repository.

@t-mat
Copy link
Contributor

t-mat commented Jun 19, 2023

Here are some logs about tipi.build for the record.

It's sad but it seems that tipi.build team keep introducing breaking changes to their environment without prior notices (from our point of view).

Since tipi.build is unstable and we don't how to test/stabilize it in our side, I think we should remove .tipi/ directory for now.
If someone is using it, they should fork xxHash and add their own "stable" .tipi/ settings. If we don't change .tipi/ directory anymore, they'll be able to git rebase easily.

Though I hope that we'll be able to re-introduce it when it'll be stabilized.

@Cyan4973 Cyan4973 merged commit 7c7a821 into dev Jun 19, 2023
t-mat added a commit to t-mat/xxHash that referenced this pull request Jun 30, 2023
Since we've merged Cyan4973#841 unfortunately, we can remove it for now.
@t-mat t-mat mentioned this pull request Jun 30, 2023
@Cyan4973 Cyan4973 deleted the notipi branch July 20, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants