Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing doxygen style comments to XXH3 family #856

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

t-mat
Copy link
Contributor

@t-mat t-mat commented Jul 10, 2023

Trivial PR which adds basic Doxygen style comment to XXH3 family funcions.

Hopefully we'll be able to introduce new CI test for documentation.

@t-mat
Copy link
Contributor Author

t-mat commented Jul 10, 2023

When I change the following line in the Doxyfile, doxygen still give me a several hundred warnings 😢

        # Until we document everything
-       WARN_IF_UNDOCUMENTED   = NO
+       WARN_IF_UNDOCUMENTED   = YES

It seems it'll need more PRs. So, I think we won't achieve this goal at 0.8.2 timely.

@Cyan4973
Copy link
Owner

Understandable, and fully acceptable outcome.

@Cyan4973 Cyan4973 merged commit bea4423 into Cyan4973:dev Jul 12, 2023
@t-mat t-mat deleted the fix/xxh3-64bits-doxygen-documents branch July 12, 2023 00:03
@Cyan4973
Copy link
Owner

Cyan4973 commented Jul 12, 2023

I was wondering, regarding doxygen documentation,
what's the better policy ?
Should it be pre-generated inside the repository, typically before a release,
or is it better to let repository users generate it on their side ?
(another option could be to provide it as a release artifact)

@t-mat
Copy link
Contributor Author

t-mat commented Jul 12, 2023

I think almost all open source project doesn't provide output of doxygen (or other document generators) as a part of release (or their repository).
Instead of it, they provides the document as web page.

For example, FLAC project releases its doxygen-generated document as https://xiph.org/flac/api/index.html

Another example is SDL. They have doxyfile. But they don't provide its output as part of their release.

@Cyan4973
Copy link
Owner

Thanks @t-mat , these are very good references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants