-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a test combining Windows + Visual + Clang-Cl + DISPATCH=1 #863
Conversation
https://github.com/Cyan4973/xxHash/actions/runs/5562735680/jobs/10161223314?pr=863#step:7:15 Since we don't see the xxHash/cmake_unofficial/CMakeLists.txt Lines 88 to 94 in 4fd75d7
|
mmmh, that doesn't work. Strangely, the same command seems to work fine in local tests on Ubuntu. |
It seems the actual Architecture ( https://github.com/Cyan4973/xxHash/actions/runs/5562735680/jobs/10161223314?pr=863#step:7:22
The following patch for # Only support DISPATCH option on x86_64.
- if("${PLATFORM}" STREQUAL "x86_64")
+ if(("${PLATFORM}" STREQUAL "x86_64") OR ("${PLATFORM}" STREQUAL "AMD64")) But it may cause error. See also #763 (comment) |
730caf1
to
22d0948
Compare
After #865, this PR should work properly. |
22d0948
to
de57565
Compare
test that #763 is fixed and remains fixed
de57565
to
a8ded18
Compare
This works great ! Thanks @t-mat ! The test will now also properly fail with a clear error signal if the produced |
https://github.com/Cyan4973/xxHash/actions/runs/5564095301/jobs/10163482759#step:7:25
https://github.com/Cyan4973/xxHash/actions/runs/5564095444/jobs/10163482094?pr=863#step:8:7
🥳 |
test that #763 is fixed and remains fixed