Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bugs and refactor #2

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Fix minor bugs and refactor #2

merged 5 commits into from
Nov 4, 2021

Conversation

shunyooo
Copy link
Contributor

@shunyooo shunyooo commented Nov 4, 2021

What changed

  • Fix kaniko version
  • Refactor type management

@shunyooo shunyooo requested review from tuxedocat and removed request for tuxedocat November 4, 2021 08:49
Copy link

@tuxedocat tuxedocat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

name: 'gcr.io/kaniko-project/executor:latest'
name: 'gcr.io/kaniko-project/executor:v1.6.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

了解です。
ask: latestのv1.7.0だと問題あった感じですか?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!こちらと同様のエラーに遭遇した形です
GoogleContainerTools/kaniko#1786

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど、理解しました! executor なので優先度は低そうですが、頭の片隅においておきます。

@shunyooo shunyooo merged commit 121ce65 into CyberAgent:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants