Revert handling of infeasible discrete parameters #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knshnb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed a performance degradation from #121 (comment) in Optuna on HPO-bench:
(_CmaEsSampler_0_NopPruner:
CMA, _CmaEsSampler_1_NopPruner:CMAwM)I found out that this is caused by #136 and #140, which repair out-of-range discrete parameters in the same way as continuous parameters.
I'm not sure why this hurt the performance this much, but let me revert these changes for now. I confirmed that this PR brings the performance back to a similar level as the original:
