Update Unity Version to 2021.3 LTS #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S20817
commented
Sep 21, 2023
S20817
commented
Sep 25, 2023
| if (_applyDistortionShader == null || renderingData.cameraData.cameraType == CameraType.Reflection) return; | ||
| if (_applyDistortionShader == null | ||
| || renderingData.cameraData.cameraType == CameraType.Reflection | ||
| || renderingData.cameraData.cameraType == CameraType.Preview) |
There was a problem hiding this comment.
ShaderGUI描画時のcameraTypeがPreviewで、その場合CameraColorTarget中身のRTが空になり、エラーになるので、それの回避判定を追加しました。
| ConfigureTarget(_renderTargetRTHandle); | ||
| #else | ||
| ConfigureTarget(_renderTargetIdentifier); | ||
| #endif | ||
| ConfigureClear(ClearFlag.Color, Color.gray); |
There was a problem hiding this comment.
@S20817
シーンの深度バッファをセットしなくなっているため、DISTORTIONの処理で深度テストが効かなくなってしまっています。
DISTORTIONはシーンに設置されている板ポリに遮蔽されている箇所に発生するのが正しい挙動だと思われますが、遮蔽されていなくても、DISTORTIONが起きるようになってしまっています。
添付している動画を参照してください。
（DistortionオブジェクトはMainCameraの下にあるので動かして確認してください。）
Bug-DistortedUvBufferPass.mp4
There was a problem hiding this comment.
あ、失念しました。深度バッファも必要ですね。修正してきます
There was a problem hiding this comment.
修正しました。
2023-09-26.12.23.14.mov
Haruma-K
approved these changes
Sep 25, 2023
S20817
force-pushed
the
feature/update2023
branch
from
8424210
to
5cc208c
Compare
S20817
commented
Sep 26, 2023
| @@ -41,15 +41,17 @@ public void Setup(RenderTargetIdentifier renderTargetIdentifier) | |||
| } | |||
| #endif | |||
|
|
|||
| public override void Configure(CommandBuffer cmd, RenderTextureDescriptor cameraTextureDescriptor) | |||
| public override void OnCameraSetup(CommandBuffer cmd, ref RenderingData renderingData) | |||
There was a problem hiding this comment.
DepthTargetをFeatureを介して設定するよりもカメラから直接取得した方がいいと思うので、ConfigureTargetの処理をConfigureからOnCameraSetupに移動しました。
CyTakayukiKiyohara
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
作業概要
作業項目
確認
TodoRTHandle対応後に、ScreenDIstortionUVをつける場合、マテリアルGUI描画する時なぜかNullエラーが出てしまいます。原因まだ調査中で、Runtimeに影響しないため、とりあえず応急処置だけをしました。