Update BBS to match new draft specs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddenlea
commented
Sep 18, 2024
|
@jeddenlea LGTM! Thank you very much for your contribution. Regarding the MSRV, I'd prefer to maintain it at 1.65 for now |
Both https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-bbs-signatures-06 and https://datatracker.ietf.org/doc/html/draft-kalos-bbs-blind-signatures-01 have been recently released. They mostly change the hashing ordering of things. Though, the blind spec also now includes a fully fledged `BlindProofVerify` and dropped `get_disclosed_data`, and blinded messages are hashed using a new sequence of generators. While updating the test fixtures I've ensured that they're all being used, some were not included. There were a couple that were `#[ignore]`'d, but actually worked just fine, so I've enabled them. The tests using the fixtures were all very formulaic, so I've tried to condense them using macros.
In the vast majority of cases, we essentially want i2osp to act like `to_be_bytes`. But, it does help to actually express things in a manner consistent with the specs. So, this makes i2osp a function with a const generic parameter to control the size of the returned array. It remains as flexible as it was, but in the vast majority of cases where a usize is turned into an 8-byte array, this compiles down to just a byte swap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-bbs-signatures-06 and https://datatracker.ietf.org/doc/html/draft-kalos-bbs-blind-signatures-01 have been recently released. They mostly change the hashing ordering of things. Though, the blind spec also now includes a fully fledged
BlindProofVerifyand droppedget_disclosed_data, and blinded messages are hashed using a new sequence of generators.While updating the test fixtures I've ensured that they're all being used, some were not included. There were a couple that were
#[ignore]'d, but actually worked just fine, so I've enabled them. The tests using the fixtures were all very formulaic, so I've tried to condense them using macros.