Changes for Linux and MOD Devices #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 17, 2016 11:34
If it's only Windows that needs it, leave it for Windows only. Overloading those is very nasty.
Using math macros is ugly, breaks std::sin and similar
All those math defines mess up with the regular math includes, and may lead to link errors due to function prototypes being different.
This reverts commit 0e68ba3.
|
Clear that Cycling74 doesn't care about running their code on Linux. |
|
@dromer sadly. bit of a waste in all honesty |
|
@lewlepton considering this was actually supposed to be some collaboration between the 2 companies .. |
|
you are over-reacting. A similar, DPF-based plugin version is available at https://github.com/moddevices/max-gen-skeleton |
|
bla, ok didn't realize that. but why keep this open for so long? this is likely to never get merged, then. |
|
Not that the dpf version worked for me: mod-audio/max-gen-skeleton#2 But I gave up on using max/msp for creating cross-platform audio plugins anyway :# |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into small commits for easier check of the changes made.
Please review and comment.