Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist parameter sorting as part of AppSettings #132

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

fde31
Copy link
Member

@fde31 fde31 commented Jun 18, 2024

No description provided.

@fde31 fde31 requested a review from x37v June 18, 2024 11:39
@fde31 fde31 force-pushed the fde/stored_sorting branch from a510c70 to 0a0ee52 Compare June 18, 2024 12:25
@fde31
Copy link
Member Author

fde31 commented Jun 18, 2024

OK also added a search input here on top of the sort persistence. Therefore this closes #117 as well

@fde31 fde31 linked an issue Jun 18, 2024 that may be closed by this pull request
Copy link
Contributor

@x37v x37v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i create 2 instances, one with 1 param and one with 2, i click the detail on the graph node to see the params then use the drop down to switch to see the detail of the other node i get an exception:

image

@fde31
Copy link
Member Author

fde31 commented Jun 18, 2024

yeah makes sense as the ids need to be recalculated. Just pushed a fix for this

@fde31 fde31 force-pushed the fde/stored_sorting branch from 7cb8942 to 46a7d92 Compare June 18, 2024 15:21
Copy link
Contributor

@x37v x37v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@fde31 fde31 merged commit 0a9b904 into develop Jun 18, 2024
1 check passed
@fde31 fde31 deleted the fde/stored_sorting branch June 18, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: search/filter for parameters
2 participants