Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/patcher rename destroy #136

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Conversation

x37v
Copy link
Contributor

@x37v x37v commented Jun 18, 2024

resolves #103

It is a bit odd that it is in the "Add Patcher Instance" area. Maybe we just need to change that button (and heading) to "Patchers" and then the button in the drawer could indicate something about adding it to the graph??

@x37v x37v requested a review from fde31 June 18, 2024 23:06
@x37v x37v force-pushed the feature/patcher-rename-destroy branch 2 times, most recently from cf3ebb0 to 7af7527 Compare June 19, 2024 13:13
@fde31
Copy link
Member

fde31 commented Jun 19, 2024

k made some UI tweaks to address that.

@fde31
Copy link
Member

fde31 commented Jun 19, 2024

sorry my fault. will address the linting issue

@x37v x37v force-pushed the feature/patcher-rename-destroy branch from de1ec39 to cb2f2b3 Compare June 19, 2024 14:03
@x37v x37v merged commit 3840dbd into develop Jun 19, 2024
1 check passed
@x37v x37v deleted the feature/patcher-rename-destroy branch June 19, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Add "patcher destroy" to allow for users to remove patchers from their device
2 participants