Normalized Instance Ports and Parameter States #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fde31
force-pushed
the
fde/normalized_instance_state
branch
2 times, most recently
from
cb802c4 to
681ce1f
Compare
|
Made some further tweaks to consolidate the |
…ing them in the instance model
…tate naming to be more coherent with naming convention of PatcherExport and PatcherInstance
fde31
force-pushed
the
fde/normalized_instance_state
branch
from
96193f6 to
67ad278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flattens the global state / reducer and moves parameter and message port records out of the nested maps associated with the instance and instead makes the connection by
instanceIndexAdditionally I added simple removal of ports and params in response to OSCQuery messages by path rather than updating the full list of ports or params associated with an instance how we did before, which was one of the reasons for the max listener warnings being logged