Add Global MIDI Mapping View #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
on thing i'm noticing is that the view doesn't render details for note mappings |
x37v
reviewed
Dec 16, 2024
|
Yeah so these other types of mapping were just not really implemented / typed I guess. I've added support for them and moved to a Max-like display / format with some relatively primitive validation in |
x37v
reviewed
Dec 17, 2024
|
k. I've hardened the parsing and display and made it a tad more flexible for unknown mapping types |
x37v
reviewed
Dec 17, 2024
x37v
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Global MIDI Mapping view. Currently it's read-only apart from clearing the mapping but should be relatively straightforward to make it possible to inline edit the MIDI Channel and CCs.
I've added a button to the left sidebar for now to access this view, reasonable?
Setting to draft for now until editing in place.
Closes #171