Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: project structure #1360

Closed
wants to merge 16 commits into from
Closed

refactor: project structure #1360

wants to merge 16 commits into from

Conversation

setchy
Copy link
Member

@setchy setchy commented Sep 7, 2024

new start of #1084

@setchy
refactor: cdxgen structure
f493d19 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
b0b591e 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
Copy link
Member Author

setchy commented Sep 7, 2024 •
edited
Loading

One of the failing tests is due to isNvmToolAvailable being missing. Also missing on master branch 🤷
https://github.com/search?q=repo%3ACycloneDX%2Fcdxgen%20isNvmToolAvailable&type=code

UPDATE: Failure is because I've updated package.json to run all **.*.test.js files, instead of a subset

@setchy
refactor: cdxgen structure
256697c 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
6971aed 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
88ce16b 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
5def56d 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
2a7879f 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
87e581f 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@prabhu prabhu requested a review from aryan-rajoria September 7, 2024 13:09
@setchy
Copy link
Member Author

setchy commented Sep 7, 2024

@aryan-rajoria - keen for your help and input on this one 🙏

@aryan-rajoria
Copy link
Collaborator

One of the failing tests is due to isNvmToolAvailable being missing. Also missing on master branch 🤷 https://github.com/search?q=repo%3ACycloneDX%2Fcdxgen%20isNvmToolAvailable&type=code

UPDATE: Failure is because I've updated package.json to run all **.*.test.js files, instead of a subset

Sorry about that the nvm tests are no longer valid. I will raise a PR to remove them.

@aryan-rajoria
Copy link
Collaborator

@aryan-rajoria - keen for your help and input on this one 🙏

Absolutely, please suggest on what I can help with?

@setchy
refactor: cdxgen structure
bae652e 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
63834ab 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
495831e 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
4c24241 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
8876f15 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
adaac2f 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor: cdxgen structure
d570390 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy changed the title refactor: cdxgen structure refactor: project structure Sep 8, 2024
@prabhu prabhu mentioned this pull request Sep 8, 2024
Merged
@aryan-rajoria
bump 10.9.10 cherry-pick from master
9b118e2 
Signed-off-by: Aryan Rajoria <aryanrajoria1003@gmail.com>
@aryan-rajoria aryan-rajoria mentioned this pull request Sep 18, 2024
Merged
@setchy
Copy link
Member Author

setchy commented Sep 19, 2024

Superseded by #1382

@setchy setchy closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryan-rajoria aryan-rajoria Awaiting requested review from aryan-rajoria

@prabhu prabhu Awaiting requested review from prabhu prabhu will be requested when the pull request is marked ready for review prabhu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @aryan-rajoria