Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages with overrides #1411

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Oct 8, 2024

Also updated tar and ssri.

Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
prabhu added 3 commits October 8, 2024 22:11
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@prabhu prabhu marked this pull request as ready for review October 8, 2024 22:01
@prabhu prabhu requested a review from aryan-rajoria October 8, 2024 22:04
@prabhu
Copy link
Collaborator Author

prabhu commented Oct 8, 2024

@aryan-rajoria could you kindly help test the docker types, including .tar files created using the docker save command? There should be no difference in the generated sbom.

@aryan-rajoria
Copy link
Collaborator

I have found some differences:
between tagged and .tar docker images, using dep-scan as example:
depscansha.json

depscantar.json

@aryan-rajoria
Copy link
Collaborator

with version 10.10.4:
depscantar-v4.json
depscansha-v4.json

lib/managers/docker.js Outdated Show resolved Hide resolved
prabhu added 2 commits October 9, 2024 10:15
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
Signed-off-by: Prabhu Subramanian <prabhu@appthreat.com>
@aryan-rajoria
Copy link
Collaborator

After bug fix:
depscantar-u1.json
depscansha-u1.json

@aryan-rajoria
Copy link
Collaborator

No differences found between this branch now and v10.10.4.
tardiff.html.json
shadiff.html.json

@prabhu prabhu merged commit 479acad into master Oct 9, 2024
24 of 25 checks passed
@prabhu prabhu deleted the feature/pkg-ignore-deprecated branch October 9, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants