Add hash, scope and deps to dart #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul <pdoherty@cergenx.com>
Signed-off-by: Paul <pdoherty@cergenx.com>
Signed-off-by: Paul <pdoherty@cergenx.com>
Signed-off-by: Paul <pdoherty@cergenx.com>
…o add_hash_to_dart
|
Thank you so much! Great improvement! |
Happy to help! Great project keep up the good work |
|
Sorry to be a nuisance, but this PR doesn't work -- it kills all repo-builds on the flutter/gallery project! When adding the --project-name and --project-version, cdxgen doesn't crash anymore, but there are lots of validation errors --> the dependencies are set to purl-type 'dart', which is incorrect -- it should be 'pub', like the components! |
|
Oops, apologies. Didn't see that the pkg type was changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pubspec for dart was an older version. Since 2.15 the sha256 is included in the lock file. Used it to add hashes to the output, along with scope and the dependencies
I updated the pubspec parsing to load it as a yaml to avoid manually having to keep track of the package
I had dart update the example pubspec file