[Gradle] SBOM generation didn't work on Windows #1615
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
Signed-off-by: Roland Asmann <roland.asmann@gmail.com>
prabhu
reviewed
Feb 3, 2025
| } | ||
| } | ||
| allOutputs.push(result.stdout); |
There was a problem hiding this comment.
How are we handling the case where stdout could be null?
prabhu
reviewed
Feb 3, 2025
| "--build-cache", | ||
| "--console", | ||
| "plain", | ||
| "--no-parallel", | ||
| ].concat(gradleArguments); | ||
| const maxCliArgsLength = isWin | ||
| ? 7500 - gradleCommandLength - mainGradleArguments.join(" ").length - 2 |
There was a problem hiding this comment.
Is 7500 the maximum gradle supports on windows?
There was a problem hiding this comment.
I am fine with creating a temporary powershell script and executing the same if it could yield good performance instead of batching.
There was a problem hiding this comment.
I hadn't thought about that yet. Let me check that out, it might make this, and your question above, moot.
There was a problem hiding this comment.
I just can't figure out how to get powershell to return the output... @prabhu, do you have any idea/experience with powershell?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cdxgen didn't generate SBOM for Gradle on Windows. This PR fixes this.
Since Windows also has a maximum character count in the CLI, this was also fixed. This unfortunately means that generating a gradle SBOM on Windows could be slower, because we potentially have to run multiple commands instead of just the one!