-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: retrieve build-system metadata from build environment #546
Conversation
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
see https://github.com/stefanbirkner/system-lambda/issues/23\#issuecomment-1007608124 Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
0ae11bd
to
026e9cb
Compare
I did not make this a configurable field, as in my use cases we want to be able to track back to the actual build that produced the SBOM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great 👍 , just left some comments.
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this feature. Left few considerations about the implementation.
Signed-off-by: Jeremy Long <jeremy.long@gmail.com>
Allows the gradle plugin to retrieve the build-system URL from the environment variables present in most CI systems. By default, this feature is disabled. However, for those who would like to include this information in the generated bom they can configure:
This will attempt to retrieve the build job URL from the CI's environment variables for several CI systems (Jenkins, GitHub Actions, Drone, Jenkins, Circle CI, and Travis CI). If not found, the
build-system
meta-data is not populated. If you are using an different CI system not listed, you can configure the feature to use alternative environment variables and even a pattern of multiple environment variables:Using multiple environment variables can be achieved using the following (note that you must use single quotes to prevent gradle from interpolating the variables):