root component gets a fallback name

fix #252 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
CycloneDX · Feb 11, 2022 · 372600f · 372600f
1 parent 26056b0
commit 372600f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/model/Bom.js b/model/Bom.js
@@ -35,7 +35,11 @@ class Bom extends CycloneDXObject {
     if (includeSerialNumber) {
       this._serialNumber = 'urn:uuid:' + uuid.v4()
     }
-    if (pkg) {
+    if (pkg && typeof pkg === 'object') {
+      if (!pkg.name) {
+        pkg = Object.assign({}, pkg) // work with a modified/fixed clone
+        pkg.name = 'NO-NAME-PACKAGE'
+      }
       this._metadata = this.createMetadata(pkg, componentType)
       this._components = this.listComponents(pkg, lockfile)
     } else {

diff --git a/model/Component.js b/model/Component.js
@@ -133,6 +133,7 @@ class Component extends CycloneDXObject {
       // bomRef defaults to PURL for backwards compatibility reasons
       this.bomRef = this.purl
     } else {
+      this.#name = '' // empty fallback just in case
       this.#hashes = new HashList()
       this.#externalReferences = new ExternalReferenceList()
     }