Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-related sub-namespaces under cdx #75

Open
lfrancke opened this issue Nov 2, 2023 · 3 comments · May be fixed by #78
Open

rust-related sub-namespaces under cdx #75

lfrancke opened this issue Nov 2, 2023 · 3 comments · May be fixed by #78
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@lfrancke
Copy link
Contributor

lfrancke commented Nov 2, 2023

We would like to record information in properties which don't have a place elsewhere.

For that we'd like to request a namespace under cdx.

Our idea is to have two namespaces: rustc (or rust?) and cargo.

@Shnatsel:

So that concepts that exist on the rustc level could still be encoded regardless of the build system. There are use cases for rustc without cargo , usually when embedding in a mixed-language project. Bazel and Meson are commonly used in this case instead of cargo.

Once a decision has been reached we're happy to provide the proper PR for this issue.
One namespace would probably be empty at this moment but the other one (rust) will include the target architecture which e.g. Go already does as well using the property name cdx:gomod:build:env:GOARCH. For rust it would probably be called rustc:target or similar.

@jkowalleck jkowalleck changed the title Request for Rust namespaces under cdx rust-related sub-namespaces under cdx Nov 2, 2023
@jkowalleck jkowalleck added the documentation Improvements or additions to documentation label Nov 2, 2023
@Shnatsel
Copy link

Shnatsel commented Nov 2, 2023

I think the best approach would be cdx:rustc:target:triple. Rationale:

  1. Decouples rustc concepts (target triple) from build system concerns (and there may be different build systems used with rustc)
  2. There are other ways to specify a target - custom target specifications exist, although currently are unstable. It would make sense to put them under cdx:rustc:target namespace once they are stabilized upstream.

Target triples are part of the compiler, not the language, so I think rustc makes more sense than rust.

@lfrancke
Copy link
Contributor Author

lfrancke commented Nov 6, 2023

@jkowalleck Any opinions/objections to the plan from @Shnatsel?
If not, one of us will send a PR with the necessary changes.

@jkowalleck
Copy link
Member

jkowalleck commented Nov 6, 2023

please send the PR 🚀

you are the experts, all i might do is nagging about naming conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
3 participants