Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cdx:rustc subnamespaces #78

Merged
merged 17 commits into from
Aug 14, 2024
Merged

Add cdx:rustc subnamespaces #78

merged 17 commits into from
Aug 14, 2024

Conversation

Shnatsel
Copy link
Contributor

@Shnatsel Shnatsel commented Nov 8, 2023 •
edited
Loading

Rendered

fixes #75

Taking over where @lfrancke left off in #77

@jkowalleck I think I've addressed your feedback on the previous iteration of this PR, PTAL.

lfrancke and others added 3 commits November 6, 2023 10:55
@lfrancke
Add rustc & cargo related subnamespaces
e23f22f 
Signed-off-by: Lars Francke <git@lars-francke.de>
@lfrancke
Saving files before committing helps. This fixes the various copy & p…
4abf24f 
…aste errors and typos

Signed-off-by: Lars Francke <git@lars-francke.de>
@Shnatsel
Rework the rustc namespace
58ad61e 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel Shnatsel requested a review from a team as a code owner November 8, 2023 22:05
@Shnatsel Shnatsel mentioned this pull request Nov 8, 2023
Closed
@Shnatsel
Add a forgotten header
362e297 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Fix components link
4865647 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
lfrancke
lfrancke suggested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues

cdx/rustc.md Outdated Show resolved Hide resolved
cdx/rustc.md Outdated Show resolved Hide resolved
@lfrancke lfrancke mentioned this pull request Nov 8, 2023
Closed
@Shnatsel
Address review comments
94d15f1 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@jkowalleck
Copy link
Member

jkowalleck commented Nov 9, 2023 •
edited
Loading

please redirect your pullrequest into the one brach of @lfrancke - https://github.com/lfrancke/cyclonedx-property-taxonomy/tree/rust
have your stuff merged

i am confused. so this #78 replaces #77?
You could just create a shared branch in one of your personal repos (grants/permission to each other) and work on a common document together. or pullrequest changes to the one repo/branch that had a pullrequest opened to "CycloneDX/cyclonedx-property-taxonomy", so that you collaborate on the same document.
get your collaboration fixed :-)

@jkowalleck jkowalleck closed this Nov 9, 2023
@jkowalleck jkowalleck reopened this Nov 9, 2023
jkowalleck
jkowalleck reviewed Nov 9, 2023
View reviewed changes
cdx/rustc.md Outdated Show resolved Hide resolved
cdx/rustc.md Outdated Show resolved Hide resolved
cdx/rustc.md Outdated Show resolved Hide resolved
cdx/rustc.md Outdated Show resolved Hide resolved
cdx/rustc.md Outdated Show resolved Hide resolved
@jkowalleck jkowalleck self-requested a review November 9, 2023 10:35
jkowalleck
jkowalleck reviewed Nov 9, 2023
View reviewed changes
cdx/rustc.md Outdated Show resolved Hide resolved
cdx/rustc.md Outdated Show resolved Hide resolved
cdx/rustc.md Outdated Show resolved Hide resolved
@jkowalleck
Copy link
Member

@Shnatsel @lfrancke please see my annotations and questions above.

@lfrancke
Copy link
Contributor

Sorry, we dropped the ball on this. I'll see if I can take a look tomorrow

@jkowalleck
Copy link
Member

@Shnatsel could you update this pr?

@Shnatsel
Copy link
Contributor Author

Shnatsel commented Aug 8, 2024

Sure, I'll take a look in the next few days.

@Shnatsel
Replace hyperlink with pathspec
e6368cf 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Specify the serialization format of booleans
3170c98 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Replace hyperlink with pathspec
09f401b 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Replace :meta with :sbom, update descriptions to clarify distinction …
e4290f0 
…from the regular build target

Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Specify what happens if neither of the properties are present
9cfa2df 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Specify that all_targets may appear at most once
94a0b05 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Merge branch 'main' into rust
358812d 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Fix typo
aebeee4 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Align table with spaces
9d3f9db 
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel
Copy link
Contributor Author

Shnatsel commented Aug 8, 2024

@jkowalleck I have addressed your feedback, adjusted the names and rewritten the descriptions for clarity. Please take another look.

@jkowalleck
Copy link
Member

this looks fantastic. <3

@jkowalleck jkowalleck changed the title Add cdx:rustc & cdx:cargo subnamespaces, take 2 Add cdx:rustc subnamespaces Aug 14, 2024
@jkowalleck jkowalleck merged commit 4b0bfa0 into CycloneDX:main Aug 14, 2024
1 of 2 checks passed
@Shnatsel Shnatsel mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfrancke lfrancke lfrancke approved these changes

@jkowalleck jkowalleck jkowalleck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rust-related sub-namespaces under cdx
3 participants
@Shnatsel @jkowalleck @lfrancke