-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cdx:rustc
subnamespaces
#78
Conversation
Signed-off-by: Lars Francke <git@lars-francke.de>
…aste errors and typos Signed-off-by: Lars Francke <git@lars-francke.de>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issues
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
please redirect your pullrequest into the one brach of @lfrancke - https://github.com/lfrancke/cyclonedx-property-taxonomy/tree/rust i am confused. so this #78 replaces #77? |
Sorry, we dropped the ball on this. I'll see if I can take a look tomorrow |
@Shnatsel could you update this pr? |
Sure, I'll take a look in the next few days. |
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
…from the regular build target Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@jkowalleck I have addressed your feedback, adjusted the names and rewritten the descriptions for clarity. Please take another look. |
this looks fantastic. <3 |
cdx:rustc
& cdx:cargo
subnamespaces, take 2cdx:rustc
subnamespaces
Rendered
fixes #75
Taking over where @lfrancke left off in #77
@jkowalleck I think I've addressed your feedback on the previous iteration of this PR, PTAL.