Add feature selection via CLI arguments #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shnatsel
changed the title
…thing yet. Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
…y working now Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Shnatsel
force-pushed
the
feature-selection
branch
from
6ee1a98
to
ad1e418
Compare
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
|
I believe this will also fix #226 |
Closed
lfrancke
requested changes
Oct 29, 2023
| // so we keep the same behavior here too. | ||
| /// Activate all available features | ||
| #[clap(long = "all-features")] | ||
| pub all_features: bool, |
There was a problem hiding this comment.
These changes need to be reflected in the README and it should probably also mention (even though it can be inferred) that by default all default features are enabled (at least I assume that's the case)
There was a problem hiding this comment.
I've copied the help messages from Cargo itself here.
I'll update the README before release, because otherwise I'll run into lots of merge conflicts. That text is not neatly split into lines, unlike code.
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Co-authored-by: Lars Francke <lars.francke@stackable.tech> Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Shnatsel
force-pushed
the
feature-selection
branch
from
b4de265
to
4fc0e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports
--no-default-features,--all-features,--features=...CLI arguments. They are fully compatible with Cargo itself, which is verified by the added tests.This allows selecting the feature configuration that matches the way you build your binaries, so that the dependency list in the SBOM can actually correspond to the binary.
Fixes #508