Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsonschema only as a dev-dependency #750

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

Shnatsel
Copy link
Contributor

Depends on #749

Fixes #741

Also add exclude directives to Cargo.toml to cut the tarball size in half.

You'd think you could just stick #[cfg(test)] on a module and call it a day, but #[cfg(test)] isn't actually set for the main crate when running integration tests. Making a separate crate for the test utils is the least clunky option: https://stackoverflow.com/a/44545091/585725

Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
…ed as a dev-dependency

Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
…lonedx-bom is fetched as a dependency. Brings down the tarball size from 3MB to somethig sane.

Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel Shnatsel requested a review from a team as a code owner July 17, 2024 04:20
Signed-off-by: Sergey "Shnatsel" Davidoff <shnatsel@gmail.com>
@Shnatsel Shnatsel merged commit 03a7d27 into CycloneDX:main Aug 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move JSON schema validation into #[test] scope
2 participants