Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust github workflow go.yml to not fail due to false positives on error test output #4

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

mrutkows
Copy link
Contributor

We have many unit tests that emit "error" output as a valid output from error tests; however, the default "go.yml" workflow provided by github does not know this. As a result, it "fails" the pre-check builds. For example:

=== RUN   TestValidateSyntaxErrorCdx13Test2
Error:  schema_formats.go(463) schema.DisplayJSONErrorDetails() JSON Syntax error: offset: 4452, line 123, character 28: invalid character '[' after object key
--- PASS: TestValidateSyntaxErrorCdx13Test2 (0.00s)

Although the test PASSED, the github action sees the word Error and fails the pre-check.

Adjust command to pass in quiet flag to unit test to not emit any output from tests at all...

…rror tests output

Signed-off-by: Matt Rutkowski <mrutkows@us.ibm.com>
Copy link
Contributor

@markstur markstur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@markstur markstur merged commit 61cb140 into main Mar 17, 2023
@markstur markstur deleted the workflow-go-fix branch March 17, 2023 17:31
@mrutkows
Copy link
Contributor Author

@markstur darn Mark that was a fast review! Thanks!

@markstur markstur restored the workflow-go-fix branch March 17, 2023 17:47
@mrutkows mrutkows deleted the workflow-go-fix branch March 17, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants