Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON strict: add optional root property $schema #107

Merged

Conversation

jkowalleck
Copy link
Member

fixes #106

fixes CycloneDX#106

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@coderpatros
Copy link
Member

coderpatros commented Dec 20, 2021

@stevespringett @DarthHater what's your thoughts on this? I consider this more an aspect of the serialization format rather than an addition to the specification. It's a non-breaking change and I think it would be good to get it included in the v1.4 release.

@stevespringett
Copy link
Member

@coderpatros agreed. And thanks @jkowalleck for pointing this out. I also believe this is a non-breaking change specific to the serialization format and completely optional.

@stevespringett stevespringett added this to the 1.4 milestone Dec 20, 2021
@stevespringett stevespringett merged commit f63f78b into CycloneDX:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON schema _strict_ must allow the property $schema
3 participants