-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/geolocate ip #123
Feature/geolocate ip #123
Conversation
needs work - currently just an api endpoint that will return geolocation data for a given IP. ToDo: - Display IP in session-card - Clicking IP opens modal with geolocation info
Add row to session card with IP Address. Clickable, opens modal. Modal WIP - displays general info about IP location (maybe can include a map within this modal?)
add padding to image
otherwise ends up on same line as subtitle info
Hey @DaftFuzz , im having some issues testing this build, can you help me with this, i created an account on maxmind, got my api key and account id, set all those up, but i get a Error Bad Request Response. is there any additional setup that needs to be done? |
Hey, so the account ID is set up as |
Okay so I managed to find the issue, the option to trace the ip is still available for local/private ips. but when its sent through the API its rejected as |
Ah, gotcha, yeah I did my testing with remote IPs only so missed that. Will make those changes 👍 |
- filter out local ip addresses - do not show modal for local ip addresses, only remote - tooltip to show local/remote
Should be resolved with the latest commit |
more consistent with stream info modal from activity table
Removed Tooltip as it was unnecessary Also added a check in the frontend. if the env variables where not set for the GEOLITE API, it would disable the option entirely
Looks all good on my side for now @DaftFuzz besides the 1 small change i added |
From this feature request.
utils/geolocateIp
. This calls the Maxmind API using env variables for authentication to return geolocation data for a given IP address