Update solc version of files after running foundryup #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexroan
approved these changes
Feb 23, 2024
|
This was reverted because it meant locally I would need to switch back manually. I'm thinking it's an issue with differences in our foundry setup, which may be OS related? |
alexroan
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained here, #173 the tests break
This happens due to 0.8.23.json files being formed rather than 0.8.21.json
(remove
outandcachefolder insidetests/contract-playgroundand runforge build)You will see that cargo test fails
This PR fixes it by renaming all references to *0.8.21.json files in the load contract tests to *.0.8.23.json
Other fixes
Cargo compile waning in
aderyn_core/src/detect/reusable/identifiers_that_reference_a_function.rs